sprite: offset-y can take % now #1014

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
6 participants

Fixes #1012

Owner

scottdavis commented Sep 14, 2012

can you update the test cases also?

I have not had time to write tests... I will do my best too soon.

ken210 commented Oct 29, 2012

Would like to see this commit merged

Owner

scottdavis commented Oct 31, 2012

Awaiting tests before merging

So this is still a work in progress right?

I have had no time to spare to get the test suite running on my machine. It
breaks. If I can get it working, then I will write tests. If anyone else
knows Ruby, feel free to write the tests and make your own fix.

On Monday, February 4, 2013, norsewulf wrote:

So this is still a work in progress right?


Reply to this email directly or view it on GitHubhttps://github.com/chriseppstein/compass/pull/1014#issuecomment-13103806.

Would love to see this merged.

@ghost ghost assigned scottdavis Dec 4, 2013

Owner

chriseppstein commented Dec 4, 2013

This has languished long enough. @scottdavis, can you either accept this patch and add some tests or reject it, please?

I attempted to run the test suite multiple times and it nearly messed up my
dev environment and still didn't run. Sorry I was not able to provide specs
for this.

On Wednesday, December 4, 2013, Chris Eppstein wrote:

This has languished long enough. @scottdavishttps://github.com/scottdavis,
can you either accept this patch and add some tests or reject it, please?


Reply to this email directly or view it on GitHubhttps://github.com/chriseppstein/compass/pull/1014#issuecomment-29855991
.

Owner

chriseppstein commented Aug 18, 2014

I've reopened the feature request. I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch.

Owner

chriseppstein commented Aug 18, 2014

Should be on top of the changes coming in #1771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment