sprite: offset-y can take % now #1014

Closed
wants to merge 2 commits into from

6 participants

@scottdavis
Compass member

can you update the test cases also?

@scottdavis
Compass member
@JaredSartin

I have not had time to write tests... I will do my best too soon.

@ken210

Would like to see this commit merged

@scottdavis
Compass member

Awaiting tests before merging

@norsewulf

So this is still a work in progress right?

@JaredSartin
@CollinY2K

Would love to see this merged.

@scottdavis scottdavis was assigned Dec 4, 2013
@chriseppstein
Compass member

This has languished long enough. @scottdavis, can you either accept this patch and add some tests or reject it, please?

@JaredSartin
@chriseppstein
Compass member

I've reopened the feature request. I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch.

@chriseppstein
Compass member

Should be on top of the changes coming in #1771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment