Add ability to set clear direction in pie-clearfix. #1032

Closed
wants to merge 1 commit into from

5 participants

@joshuajabbour

Add argument to pie-clearfix mixin for clear direction. Defaults to 'both'.

Sometimes you need to be able to set this to not blow up floated layouts.

@joshuajabbour joshuajabbour Add ability to set clear direction in pie-clearfix.
Add argument to pie-clearfix mixin for clear direction. Defaults to 'both'.
ada1a54
@mirisuzanne
Compass member

Cool. I like this idea, and never even thought to try it.

As a new feature I think it belongs in the master branch. Can you re-submit there? Thanks!

@scottdavis
Compass member

Needs a test case

@robwierzbowski

I don't see a reason for adding this. Clearing the :after pseudoelement just forces the parent element to contain floats, and to do that effectively it should be set to clear: both. It should have no impact on the position of floated elements inside the parent element, and no impact on the position of the parent element itself if it is floated.

@chriseppstein
Compass member

Agree with @robwierzbowski shouldn't be necessary. Please provide a clear use case if you want us to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment