New Flexbox Mixins #1218

Merged
merged 10 commits into from Apr 1, 2013

Conversation

Projects
None yet
4 participants
@cimmanon

New mixins that support all 3 Flexbox implementations (see: #921). There is a variable name conflict with the old "box" collection: $flexbox-support. I went with naming the support variables after the display property that goes along with it since the year thing might be a little confusing (especially since some articles refer to the Mar 2012 spec as 2011):

  • $flex-support (Sept 2012)
  • $flexbox-support (Mar 2012)
  • $box-support (July 2009)

Examples will be in a later pull request.

@frapontillo

This comment has been minimized.

Show comment
Hide comment
@frapontillo

frapontillo Mar 28, 2013

ms and o prefixes should be inverted, per specification, in $flex-support, $flexbox-support, $box-support.
Please see my comment on issue #921.

ms and o prefixes should be inverted, per specification, in $flex-support, $flexbox-support, $box-support.
Please see my comment on issue #921.

@cimmanon

This comment has been minimized.

Show comment
Hide comment
@cimmanon

cimmanon Mar 28, 2013

The experimental() mixin I'm depending on uses this order: moz, webkit, ms, o, khtml, standard. See this commit to the master branch and #1000 for the reasoning behind the change in prefix order.

The experimental() mixin I'm depending on uses this order: moz, webkit, ms, o, khtml, standard. See this commit to the master branch and #1000 for the reasoning behind the change in prefix order.

@mirisuzanne

This comment has been minimized.

Show comment
Hide comment
@mirisuzanne

mirisuzanne Mar 28, 2013

Member

I'm ready to pull this in, but it should have docs and an entry in the changelog. Can you do that? Check the documentation readme for more on how docs are generated.

Member

mirisuzanne commented Mar 28, 2013

I'm ready to pull this in, but it should have docs and an entry in the changelog. Can you do that? Check the documentation readme for more on how docs are generated.

@cimmanon

This comment has been minimized.

Show comment
Hide comment
@cimmanon

cimmanon Mar 28, 2013

Yes, I'll get that done this weekend.

Yes, I'll get that done this weekend.

@cimmanon

This comment has been minimized.

Show comment
Hide comment
@cimmanon

cimmanon Mar 31, 2013

I'm not able to test to make sure the examples/docs work since I can't get bundler to do its job (ruby_prof is failing to compile).

I'm not able to test to make sure the examples/docs work since I can't get bundler to do its job (ruby_prof is failing to compile).

mirisuzanne added a commit that referenced this pull request Apr 1, 2013

@mirisuzanne mirisuzanne merged commit e9295c5 into Compass:master Apr 1, 2013

@mirisuzanne

This comment has been minimized.

Show comment
Hide comment
@mirisuzanne

mirisuzanne Apr 1, 2013

Member

Thanks! We can make adjustments still as needed.

Member

mirisuzanne commented Apr 1, 2013

Thanks! We can make adjustments still as needed.

@scottdavis

This comment has been minimized.

Show comment
Hide comment
@scottdavis

scottdavis Apr 1, 2013

Member

Docs do not build with this merge:

Loading site data…
Compiling site…
      update  [0.00s]  output/blog/atom.xml
      update  [0.02s]  output/CHANGELOG/index.html

Captain! We’ve been hit!

Message:

Haml::SyntaxError: Illegal nesting: content can't be both given on the same line as %div and nested within it.

Compilation stack:

  - [item]   /examples/compass/css3/flexbox/_flexbox/ (rep default)

Stack trace:

  0. item /examples/compass/css3/flexbox/_flexbox/ (rep default):2
  1. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:341:in `tag'
  2. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:359:in `div'
  3. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:185:in `process_line'
  4. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:148:in `parse'
  5. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/engine.rb:124:in `initialize'
  6. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/filters/haml.rb:23:in `new'
  7. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/filters/haml.rb:23:in `run'
  8. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/base/result_data/item_rep.rb:348:in `filter'
  9. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/base/compilation/item_rep_proxy.rb:47:in `filter'
  ... 32 more lines omitted. See full crash log for details.

Member

scottdavis commented Apr 1, 2013

Docs do not build with this merge:

Loading site data…
Compiling site…
      update  [0.00s]  output/blog/atom.xml
      update  [0.02s]  output/CHANGELOG/index.html

Captain! We’ve been hit!

Message:

Haml::SyntaxError: Illegal nesting: content can't be both given on the same line as %div and nested within it.

Compilation stack:

  - [item]   /examples/compass/css3/flexbox/_flexbox/ (rep default)

Stack trace:

  0. item /examples/compass/css3/flexbox/_flexbox/ (rep default):2
  1. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:341:in `tag'
  2. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:359:in `div'
  3. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:185:in `process_line'
  4. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/parser.rb:148:in `parse'
  5. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/haml-3.1.7/lib/haml/engine.rb:124:in `initialize'
  6. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/filters/haml.rb:23:in `new'
  7. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/filters/haml.rb:23:in `run'
  8. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/base/result_data/item_rep.rb:348:in `filter'
  9. /Users/sdavis/.rvm/gems/ruby-1.9.3-p392/gems/nanoc-3.4.3/lib/nanoc/base/compilation/item_rep_proxy.rb:47:in `filter'
  ... 32 more lines omitted. See full crash log for details.

@mirisuzanne

This comment has been minimized.

Show comment
Hide comment
@mirisuzanne

mirisuzanne Apr 6, 2013

Member

The local doc setup has been fixed, and I got the flexbox docs running. They're a bit ugly at the moment, though. @cimmanon can you take a look at that? See if you can get them working locally, and clean them up a bit? I had to run bundle install and then ./bin/nanoc aco.

Member

mirisuzanne commented Apr 6, 2013

The local doc setup has been fixed, and I got the flexbox docs running. They're a bit ugly at the moment, though. @cimmanon can you take a look at that? See if you can get them working locally, and clean them up a bit? I had to run bundle install and then ./bin/nanoc aco.

@cimmanon

This comment has been minimized.

Show comment
Hide comment
@cimmanon

cimmanon Apr 6, 2013

Trying to get the docs running broke quite a few things on my virtual box. A library Git depends on is missing and I can't build a gem for Compass anymore. I'm stuck until I can get my husband to fix it for me.

cimmanon commented Apr 6, 2013

Trying to get the docs running broke quite a few things on my virtual box. A library Git depends on is missing and I can't build a gem for Compass anymore. I'm stuck until I can get my husband to fix it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment