Added support for spacing to smart sprite layouts. #1314

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@j4james

This makes no changes to the RowFitter calculations - it merely adds spacing around the sprites after they've already been divided into rows. As a result, this could potentially generate a suboptimal layout given the right combination of images and spacing settings, but I suspect that would be fairly unlikely in most use cases. If it is deemed to be a major issue, the RowFitter algorithm could always be optimised at a later stage.

@jdmarshall

I have been having the same issue and I would love to see/help this get merged.

@simonrenoult

Hi,
Is there some news about this issue ? I would also love to this see this get merged !

@estahn

👍

@scottdavis scottdavis was assigned Dec 3, 2013
@chriseppstein
Compass member

I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch.

@scottdavis has extracted sprites to a plugin and we'll be releasing that in 1.1. This needs to be patch on top of his work which should land soon.

@chriseppstein
Compass member

Should be on top of the changes coming in #1771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment