Deprecate reset-baseline mixin from vertical-rhythm partial #790

Closed
wants to merge 1 commit into from

3 participants

@JohnAlbin

Follow-up to #780 to deprecate reset-baseline() mixin.

@chriseppstein
Compass member

@JohnAlbin Thanks for this patch. We need to add an @warn to the mixin as well so that users who are using it are made aware. Here's an example of this pattern in action: https://github.com/chriseppstein/compass/blob/stable/frameworks/compass/stylesheets/compass/css3/_box-shadow.scss#L63

@scottdavis
Compass member

whats going on with this? :bump:

@JohnAlbin

Sorry. I was at a conference for 10 days and on vacation for a week.

I just pushed a new commit. Does that @warn text in that commit look okay?

@JohnAlbin

Sorry, pushed wrong commit before. I've updated the commit properly and then rebased it against master.

Warning says:

This mixin has been deprecated and will be removed in the next version. Use adjust-leading-to(1) instead.

@scottdavis
Compass member

@ericam can you verify that this went in with the big VR patch?

@scottdavis
Compass member

Its depricated

@scottdavis scottdavis closed this Feb 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment