Update docs for reset-baseline() in vertical_rhythm partial #791

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

JohnAlbin commented Mar 14, 2012

Over in #780 the decision was made to deprecate the reset-baseline() partial in the master branch that will be Compass 0.13 (which I did in #790).

But we still need to better document that mixin in the stable 0.12 branch.

Here's a better description of the mixin with a mild warning about it not working in all circumstances.

Contributor

ry5n commented Mar 14, 2012

@JohnAlbin +1, although I'd make it clear why it won't work and when: “does not work on elements whose font-size is different from $base-font-size”

Owner

scottdavis commented Mar 16, 2012

Go ahead and fix the typo and just make it @include adjust-leading-to(1, $base-font-size); and put a @warn in there and ill merge this in.

Owner

chriseppstein commented Mar 18, 2012

I took @ry5n's feedback into account -- this is on stable now as 3f96108 and 1aca960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment