Replace #root_footer with :after pseudo-element #986

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

krulik commented Aug 9, 2012

We can remove the extra markup element and have a cleaner HTML structure.
The downside is that a user-defined pseudo-element of the #root can interfere with the sticky-footer one.

Contributor

MoOx commented Aug 9, 2012

Maybe better to set #root_footer as :after by default, allowing people to set another element (to support IE7 ?)

krulik commented Aug 9, 2012

This is a good idea. However we will still need to add the content: ""; display: block; stuff for this to work.

Replace root_footer-selector to &:after by default
A less obtrusive way to replace the extra markup element.

Well the "support for IE7" variable could be used no ?

Contributor

MoOx commented Aug 9, 2012

I think so.

krulik commented Aug 9, 2012

I don't think you need anything explicit for IE7 - now it's :after by default but you can still overwrite it if you want to. It also doesn't break the mixin signature this way, much less obtrusive.

Owner

mirisuzanne commented Aug 9, 2012

I like this, but I think it belongs in the master branch, not the stable branch. It should also be documented, with tests, and added to the changelog. This is likely to affect everyone using the mixin, so we can't do it without warning.

krulik commented Aug 9, 2012

@ericam Fair, I'm new here and I feel that I need some contribution guidelines. Where can I find some? I've looked in the Wiki and the website and didn't find anything like that. How do I document/test/changelog? What branches are for what purpose? Sorry for n00b questions :)

Owner

mirisuzanne commented Aug 9, 2012

@krulik No worries. The contribution guidelines are on the site: http://compass-style.org/help/tutorials/contributing/

Let me know if you have more questions. Thanks for the contribution!

Owner

chriseppstein commented Dec 4, 2013

Closing due to lack of updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment