postfix_prevent_unrestricted_relay: allow whitespaces and no comma for 'smtpd_client_restrictions' value

[rmetrich]

Rule xccdf_org.ssgproject.content_rule_postfix_prevent_unrestricted_relay

Description:

The postconf(5) manpage specifies that values can be separated by commas and/or whitespace for smtpd_client_restrictions property.

Rationale:

The following specifications should be valid:

smtpd_client_restrictions = permit_mynetworks,reject
smtpd_client_restrictions = permit_mynetworks, reject
smtpd_client_restrictions = permit_mynetworks reject
smtpd_client_restrictions = permit_mynetworks  ,  reject
smtpd_client_restrictions = permit_mynetworks    reject

[openshift-ci]

Hi @rmetrich. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[Mab879]

/ok-to-test

[marcusburghardt]

/retest

[marcusburghardt]

Could you include a test scenarios these variations, please?

[codeclimate]

Code Climate has analyzed commit 2d03f86 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

[marcusburghardt]

All tests have passed in local VMs too.
I am fine to merge this PR as it is, but I have three comments that would be good to keep in mind for next PRs:

• in general, after a request for changes, it is preferable to send more commits instead of amending the previous commits and forcibly pushing the changes. This way we can see the last changes and it makes the review time much faster.
• the ok prefix is not necessary in pass test scenarios
• each test scenario increases a little bit the testing time, it is not the case here but consider to unify similar tests whenever reasonable

Thanks for the fix and hope to see more PRs from you. : )

[marcusburghardt]

The test scenarios already have a suffix pass or fail.
https://complianceascode.readthedocs.io/en/latest/tests/README.html#test-scenarios

It seems redundant to use the ok prefix in the name of pass scripts. I would prefer to remove them, but would also be fine with this in this specific PR since there is not technical impact in this case. Only keep this in mind for the next PRs, please.

[rmetrich]

Comments noted for next time. I'm used to squash things because usually other projects do not tolerate unsquashed commits...