Skip to content

coredump_disable_backtraces: depend on systemd being installed #10321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

candrews
Copy link
Contributor

@candrews candrews commented Mar 9, 2023

Description:

coredump_disable_backtraces: depend on systemd being installed

Rationale:

coredump_disable_backtraces only makes sense if systemd is installed because it checks systemd configuration files and relies on systemd behavior.

Review Hints:

With this change applied, oscap-podman ubuntu:22.04 xccdf eval --report report.html --profile xccdf_org.ssgproject.content_profile_standard /usr/share/xml/scap/ssg/content/ssg-ubuntu2204-ds.xml should yield a report indicating that the "Disable core dump backtraces" rule is "Not Applicable

coredump_disable_backtraces only makes sense if systemd is installed
because it checks systemd configuration files and relies on systemd
behavior.

Signed-off-by: Craig Andrews <candrews@integralblue.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2023

Hi @candrews. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Mar 9, 2023

Code Climate has analyzed commit 4eb0e51 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Mar 10, 2023
@jan-cerny jan-cerny added this to the 0.1.67 milestone Mar 10, 2023
@jan-cerny jan-cerny merged commit 4e6de19 into ComplianceAsCode:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants