Repository navigation
Conversation
coredump_disable_storage only makes sense if systemd is installed because it checks systemd configuration files and relies on systemd behavior. Signed-off-by: Craig Andrews <candrews@integralblue.com>
|
Hi @candrews. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 16cf491 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
2 participants
Description:
coredump_disable_storage: depend on systemd being installed
Rationale:
coredump_disable_storage only makes sense if systemd is installed because it checks systemd configuration files and relies on systemd behavior.
Review Hints:
With this change applied,
oscap-podman ubuntu:22.04 xccdf eval --report report.html --profile xccdf_org.ssgproject.content_profile_standard /usr/share/xml/scap/ssg/content/ssg-ubuntu2204-ds.xmlshould yield a report indicating that the "Disable storing core dump" rule is "Not Applicable