Skip to content

iptables_ruleset_modifications: depend on iptables being installed - #11030

Merged
marcusburghardt merged 1 commit into
ComplianceAsCode:masterfrom
candrews:iptables
Aug 28, 2023
Merged

marcusburghardt merged 1 commit into
ComplianceAsCode:masterfrom
candrews:iptables

Conversation

@candrews

Copy link
Copy Markdown
Contributor

Description:

iptables_ruleset_modifications: depend on iptables being installed

Rationale:

iptables rules are only applicable when iptables is installed

Review Hints:

iptables rules are only applicable when iptables is installed

Signed-off-by: Craig Andrews <candrews@integralblue.com>
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 26, 2023
@openshift-ci

openshift-ci Bot commented Aug 26, 2023

Copy link
Copy Markdown

Hi @candrews. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions

Copy link
Copy Markdown
Contributor

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 04555fe and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Aug 28, 2023
@marcusburghardt marcusburghardt added the Update Rule Issues or pull requests related to Rules updates. label Aug 28, 2023
@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Aug 28, 2023
@marcusburghardt marcusburghardt added the CPE-AL CPE Applicability Language label Aug 28, 2023

@marcusburghardt marcusburghardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt
marcusburghardt merged commit 3136c5c into ComplianceAsCode:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CPE-AL CPE Applicability Language needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants