Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include @platform in <fix> element #1515

Merged
merged 1 commit into from Oct 19, 2016
Merged

Don't include @platform in <fix> element #1515

merged 1 commit into from Oct 19, 2016

Conversation

mpreisler
Copy link
Member

This is a fix for a serious regression, the remediations won't be run at all if the attribute is included! Since we have one benchmark per product it makes no sense to include it anyway.

Regression was introduced in:
#1491

Thanks goes to @bkogami and @xmtrcv who have reported this issue.

Fixes #1509

Don't include @platform in <fix> element
1693879 
This is a fix for a serious regression, the remediations won't be run
at all if the attribute is included! Since we have one benchmark per
product it makes no sense to include it anyway.

Regression was introduced in:
ComplianceAsCode#1491
@mpreisler mpreisler added bugfix Fixes to reported bugs. BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax Infrastructure Our content build system labels Oct 19, 2016
@mpreisler mpreisler added this to the 0.1.31 milestone Oct 19, 2016
@mpreisler mpreisler mentioned this pull request Oct 19, 2016
Closed
@mpreisler
Copy link
Member Author

If we decide we really want the platform element included it MUST be the CPE ID and not a human readable platform name such as "Red Hat Enterprise Linux 6". I think we should not include it because it would just repeat RHEL6 for all fixes in the RHEL6 benchmark.

@redhatrises
Copy link
Contributor

Ack.

I think we should not include it because it would just repeat RHEL6 for all fixes in the RHEL6 benchmark.

Agreed.

@redhatrises redhatrises merged commit 899a586 into ComplianceAsCode:master Oct 19, 2016
@mpreisler mpreisler deleted the dont_include_platform_in_fix_element branch October 19, 2016 19:31
@xmtrcv
Copy link

xmtrcv commented Oct 19, 2016 •
edited

Applied #1515 changes manually to combineremediations.py
Removed old content from RHEL/6/output, and re-ran 'make'
Ran 'oscap eval xccdf --remediate' against RHEL/6/output/ssg-rhel6-ds.xml
Fixes are now applied

edit:
Verified 'oscap eval xccdf --remediate' against RHEL/7/ssg-rhel7-ds.xml applies fixes also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redhatrises redhatrises

Labels
BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax bugfix Fixes to reported bugs. Infrastructure Our content build system
Projects
None yet
Milestone
0.1.31
Development

Successfully merging this pull request may close these issues.

Error when using --fetch-remote-resources
3 participants
@mpreisler @redhatrises @xmtrcv