Removed the old JBossFuse6 content, this content is obsolete and does… #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2016 15:58
…n't work The XCCDF has been broken by 99361a0 and nobody ever complained. Therefore I think nobody is using this. The OVAL doesn't validate either...
|
Added 2 commits that remove |
|
@mpreisler |
|
@mpreisler good with removing the old JBossFuse6 content. I don't think that it is a controversial removal as it should be building normally. |
mpreisler
force-pushed
the
nuke_jbossfuse6_old_content
branch
from
1ed3447 to
baad027
Compare
|
@redhatrises Removed the two commits and push forced. Now this PR is only removing JBossFuse6. |
|
Ack for this PR. Please wait until next week to merge just in case there are concerns raised. |
|
On 11/28/16 4:03 PM, Martin Preisler wrote:
…n't work. It has been replaced by |JBoss/Fuse/6| content.
The XCCDF of the old content has been broken by 99361a0
<99361a0>
and nobody ever complained -- the |Benchmark| element was removed.
Therefore I think nobody is using this. The OVAL doesn't validate
either...
*THIS IS CONTROVERSIAL, PLEASE WAIT A BIT BEFORE MERGING* If nobody
speaks out in a week I think it's safe to merge.
Do we want to remove the JBossEAP5 content as well? It has been
obsoleted by |JBoss/EAP/5|.
The Fuse6 content was written for XCCDFExec interpreter (not OpenSCAP).
Was authored by Bryan Saunders, Jason Wong and Kenny Peeples in support
of a US Gov customer (Navy, IIRC). Pinging them to get the latest.
|
|
Any objections to merging this PR? Would like to merge this by Friday. |
|
As no one has responded since 12 days ago, I am going to go ahead and merge. We can revert if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n't work. It has been replaced by
JBoss/Fuse/6content.The XCCDF of the old content has been broken by 99361a0 and nobody ever complained -- the
Benchmarkelement was removed. Therefore I think nobody is using this. The OVAL doesn't validate either...THIS IS CONTROVERSIAL, PLEASE WAIT A BIT BEFORE MERGING If nobody speaks out in a week I think it's safe to merge.
Do we want to remove the JBossEAP5 content as well? It has been obsoleted by
JBoss/EAP/5.