Create script to build datastream images from source #5153
Conversation
|
Note that this makes some assumptions (e.g. the naming scheme of the ds file is ssg--ds.xml). This works for ocp4 and that's what I tested. I haven't tested this for rhel yet. |
JAORMX
force-pushed
the
build-ds-container
branch
from
e42447a to
611f46e
Compare
|
Just tested it with RHEL and did some fixes. |
There was a problem hiding this comment.
LGTM from the point of view of the openshift commands and the Dockerfile etc. I'll let someone from the CaC team chime in whether the root of the dir is the best location for the script. But it looks good to me, thank you!
Also, if there's any developer documentation maybe it should be amended to point to this new script. But that can be done in a separate PR, let's get this one merged so that people can experiment with the content creation easily
|
@JAORMX Great! Thanks. Please move it to |
This script runs the build_product script (taking the product as a
parameter), and it pushes the ssg-$PRODUCT-ds.xml file to a container.
The container is created by using a BuildConfig and an ImageStream,
these are updated by pushing the local xml file to the container build.
This is just one step of the build process which helps with local
development. In further iterations I'll create a BuildConfig that builds
inside a container as opposed to requiring a local file.
Example:
./utils/build_ds_container.sh ocp4
JAORMX
force-pushed
the
build-ds-container
branch
from
611f46e to
076c0b1
Compare
|
@jan-cerny done! thanks for the feedback |
This script runs the build_product script (taking the product as a
parameter), and it pushes the
ssg-$PRODUCT-ds.xmlfile to a container.The container is created by using a BuildConfig and an ImageStream,
these are updated by pushing the local XML file to the container build.
This is just one step of the build process which helps with local
development. In further iterations, I'll create a BuildConfig that builds
inside a container as opposed to requiring a local file.
Example: