Skip to content

ocp4: Remove the rule that disables user namespaces #5268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

jhrozek
Copy link
Collaborator

@jhrozek jhrozek commented Mar 10, 2020

Description:

Do not disable user namespaces via sysctl for RHCOS.

Rationale:

As the rule itself says, we should not disable the support for user
namespaces on container hosts such as RHCOS.

As the rule itself says, we should not disable the support for user
namespaces on container hosts such as RHCOS.
@redhatrises
Copy link
Contributor

@jhrozek should we actually specify the values that are needed for sysctl_user_max_user_namespaces?

@jhrozek
Copy link
Collaborator Author

jhrozek commented Mar 10, 2020 via email

@redhatrises
Copy link
Contributor

On Tue, Mar 10, 2020 at 07:57:11AM -0700, Gabe Alford wrote: @jhrozek should we actually specify the values that are needed for sysctl_user_max_user_namespaces?
Do you mean the value for the actual sysctl parameter? Do you think we should override the default?

@jhrozek was thinking if the RHCOS content should be opinionated in setting the expected sysctl_user_max_user_namespaces value for RHCOS rather than disabling it. Like the value should be greater than 0, "1500", or some other value. It may not make sense as sysctl_user_max_user_namespaces might need to be dynamic. Just curious if the policy should be opinionated about a value instead of disabling it.

@jhrozek
Copy link
Collaborator Author

jhrozek commented Mar 11, 2020 via email

@jhrozek
Copy link
Collaborator Author

jhrozek commented Mar 11, 2020

@JAORMX do you have an opinion on this PR?

@JAORMX
Copy link
Contributor

JAORMX commented Mar 12, 2020

I think we should stick with the default. User namespaces are crucial for containers and the numbers will increase in the foreseeable future due to the move to rootless containers. So my take is : let's not mess with this so we don't break deployments.

@redhatrises
Copy link
Contributor

Sounds good. Thanks @jhrozek @JAORMX ! We can re-review later anyways if some security reason pops up. Ack

@redhatrises redhatrises merged commit 6b67818 into ComplianceAsCode:master Mar 13, 2020
@yuumasato yuumasato added this to the 0.1.50 milestone Mar 13, 2020
@shawndwells shawndwells requested a review from redhatrises March 21, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants