Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commented section for OCP4 CIS etcd node checks #6238

Merged
merged 1 commit into from Oct 14, 2020

Conversation

lbragstad
Copy link
Contributor

Some of the etcd checks in OCP4 are node checks that we can automate,
but we need to add them to the cis-node.profile instead of the
cis.profile.

This commit prepares for those changes by adding the applicable checks
as commented sections in the cis-node.profile. Subsequent patches will
fill in each etcd check.

Some of the etcd checks in OCP4 are node checks that we can automate,
but we need to add them to the cis-node.profile instead of the
cis.profile.

This commit prepares for those changes by adding the applicable checks
as commented sections in the cis-node.profile. Subsequent patches will
fill in each etcd check.
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@openshift-ci-robot
Copy link
Collaborator

Hi @lbragstad. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Used by openshift-ci bot. label Oct 14, 2020
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAORMX
Copy link
Contributor

JAORMX commented Oct 14, 2020

@openscap-ci test this please

@matejak
Copy link
Member

matejak commented Oct 14, 2020

I merge the PR, as it has been approved, and doesn't introduce any functional changes.

@matejak matejak merged commit 2dfc215 into ComplianceAsCode:master Oct 14, 2020
@yuumasato yuumasato added this to the 0.1.53 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants