-
Notifications
You must be signed in to change notification settings - Fork 743
Add readthedocs documentation support #6299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readthedocs documentation support #6299
Conversation
|
Hello @ggbecker! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-11-09 16:31:49 UTC |
|
Changes identified: Show detailsOthers: Recommended tests to execute: |
8810718 to
68c751b
Compare
|
It's amazing! Suggestions:
Why are HTML tags used in the markdown docs? |
Thank you for the suggestions. I'll update accordingly. HTML tags were automatically generated when converting from |
|
|
The webhook to trigger builds on readthedocs is already in place, so pushes to master branch and new releases will automatically have the documentation generated |
0b3d807 to
bd55667
Compare
|
Python modules have been added to the documentation. You can preview the latest state here: https://ggbecker-content.readthedocs.io/en/readthedocs-support/ |
Is the developer guide readable without an internet connect in the repo itself? If not, that needs to be taken care of. Never assume access to an internet resource to read documentation. |
The documentation still lives in the repo. They were just split and reside on a different directory: https://github.com/ggbecker/content/tree/readthedocs-support/docs/manual/developer The documentation could be also built locally using sphinx tools and we can add as a target in the make command so users can have the same HTML files that readthedocs generate. If we think about it, users that browse files locally, would also need to have a |
|
Recently added docs for the ocp4 e2e tests #6319 any chance that could be included? |
Definitely. Thanks for the reminder. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's amazing.
I appreciate the idea of adding the Python modules documentation.
In future I suggest reshuffling the sections and chapters a bit, because for example templates are hidden well.
f548c48 to
7fc92af
Compare
It should be enough to just instruct users to use pip. It will use the default python target of user's machine.
7fc92af to
356cb49
Compare
|
/test e2e-aws-rhcos4-e8 test flake |
|
Great, I see no objections, and the existing documentation has just been converted to Markdown, which means that it's prefectly usable offline. |
Description:
adoc, it was needed to convert some stuff around to markdown.A preview of how the documentation will look like can be seen in:
https://ggbecker-content.readthedocs.io/en/readthedocs-support/
Rationale:
TODO List
- [ ] Port changes from: 1 (can be incorporated when it gets merged)- [ ] Migrate tests/README.md- [ ] Migrate docs/user_guide.adoc- [ ] Migrate example/README.mdUpdate1: Reduce the scope a bit so this can be merged and then other files can be migrated later.