New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override build date with SOURCE_DATE_EPOCH #6642
Conversation
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. Without this patch, .xml files varied for each build in <oval:timestamp>2021-02-22T21:05:22</oval:timestamp> This PR was done while working on reproducible builds for openSUSE.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Hi @bmwiedemann. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openscap-ci ok to test |
|
Changes identified: Show detailsOthers: Recommended tests to execute: |
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm going to add documentation about this on a subsequential PR.
Description:
SOURCE_DATE_EPOCHin order to make builds reproducible.
This PR was done while working on reproducible builds for openSUSE.
Rationale:
.xmlfiles varied for each build in