Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #6642

Merged
merged 1 commit into from Mar 2, 2021
Merged

Allow to override build date with SOURCE_DATE_EPOCH #6642

merged 1 commit into from Mar 2, 2021

Conversation

bmwiedemann
Copy link
Contributor

Description:

  • Allow to override build date with SOURCE_DATE_EPOCH
    in order to make builds reproducible.

This PR was done while working on reproducible builds for openSUSE.

Rationale:

    <oval:timestamp>2021-02-22T21:05:22</oval:timestamp>

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Without this patch, .xml files varied for each build in

    <oval:timestamp>2021-02-22T21:05:22</oval:timestamp>

This PR was done while working on reproducible builds for openSUSE.
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@openshift-ci-robot
Copy link
Collaborator

Hi @bmwiedemann. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggbecker
Copy link
Member

@openscap-ci ok to test

@openscap-ci
Copy link
Collaborator

openscap-ci commented Feb 25, 2021

Changes identified:
Others:
 Changes in Python files.

Show details

Others:
 Python abstract syntax tree change found in ssg/constants.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)

@bmwiedemann bmwiedemann mentioned this pull request Feb 25, 2021
@jan-cerny
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Mar 1, 2021
@ggbecker ggbecker self-assigned this Mar 2, 2021
Copy link
Member

@ggbecker ggbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to add documentation about this on a subsequential PR.

@ggbecker ggbecker merged commit d931592 into ComplianceAsCode:master Mar 2, 2021
9 checks passed
@yuumasato yuumasato added this to the 0.1.55 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants