Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort file lists #6647

Merged
merged 1 commit into from Mar 1, 2021
Merged

Sort file lists #6647

merged 1 commit into from Mar 1, 2021

Conversation

bmwiedemann
Copy link
Contributor

Description:

  • Sort file lists

Rationale:

See https://reproducible-builds.org/ for why this is good.

Together with #6642 and OpenSCAP/openscap#1699 this allowed for bit-identical results.
Probably some of this change is not needed, but build was slow, so I did not try to reduce the patch.

This PR was done while working on reproducible builds for openSUSE.

@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@openscap-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@openshift-ci-robot
Copy link
Collaborator

Hi @bmwiedemann. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Used by openshift-ci bot. label Feb 25, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 25, 2021

Hello @bmwiedemann! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 66:30: E128 continuation line under-indented for visual indent

Comment last updated at 2021-02-25 21:16:37 UTC

so that xml files build in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.
@JAORMX
Copy link
Collaborator

JAORMX commented Feb 26, 2021

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Feb 26, 2021
@jan-cerny jan-cerny self-assigned this Mar 1, 2021
@jan-cerny jan-cerny added this to the 0.1.55 milestone Mar 1, 2021
@jan-cerny
Copy link
Contributor

Thank you!

@jan-cerny jan-cerny merged commit 7d66523 into ComplianceAsCode:master Mar 1, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants