Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and select seboolean rules for R67 #6988

Merged
merged 1 commit into from
May 11, 2021

Conversation

yuumasato
Copy link
Member

Description:

  • Fix description of sebool_deny_execmem, and warning about possible
    issues.
  • Add rationale to rules the SELinux booleans.

Rationale:

  • Supports ANSSI R67

@yuumasato
Copy link
Member Author

@openscap-ci test this please

@JAORMX
Copy link
Contributor

JAORMX commented May 11, 2021

 Please, check if the contents below are correctly expanded:
Source yaml: /content/linux_os/guide/system/selinux/selinux-booleans/sebool_deny_execmem/rule.yml 

@yuumasato
Copy link
Member Author

@JAORMX Thanks, that issue is fixed.
Now the build fails only in the rhel7 node, :/

Exception while handling file: /home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/build/rhel7/rules/sebool_deny_execmem.yml
Traceback (most recent call last):
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/utils/gen_tables.py", line 93, in <module>
    result = output_class_map[args.output_type](args.product, args.build_dir).get_result()
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/utils/gen_tables.py", line 48, in __init__
    rule = ssg.build_yaml.Rule.from_yaml(r_file)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/build_yaml.py", line 1087, in from_yaml
    yaml_contents = open_and_macro_expand(yaml_file, env_yaml)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/yaml.py", line 102, in open_and_macro_expand
    return open_and_expand(yaml_file, substitutions_dict)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/yaml.py", line 85, in open_and_expand
    yaml_contents = _open_yaml(expanded_template, yaml_file, substitutions_dict)
  File "/home/jenkins/workspace/scap-security-guide-pull-requests/label/rhel7/ssg/yaml.py", line 70, in _open_yaml
    raise e
yaml.constructor.ConstructorError: could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'
  in "<unicode string>", line 36, column 23

Fix description of sebool_deny_execmem, and warning about possible
issues.
Add rationale to rules the SELinux booleans.
@jan-cerny jan-cerny self-assigned this May 11, 2021
@jan-cerny jan-cerny merged commit ac2bbf0 into ComplianceAsCode:master May 11, 2021
@yuumasato yuumasato deleted the anssi_sebool branch May 11, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants