-
Notifications
You must be signed in to change notification settings - Fork 743
Initial definition of ANSSI BP28 minmal profile for SLE #8540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial definition of ANSSI BP28 minmal profile for SLE #8540
Conversation
|
Hi @teacup-on-rockingchair. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi, |
Please forget this comment. Should have read things more closely. Sorry for the noise. |
|
Hello @teacup-on-rockingchair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-05-02 14:57:10 UTC |
|
This datastream diff is auto generated by the check Click here to see the full diffbash remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_password_pam_unix_rounds_password_auth' differs:
--- old datastream
+++ new datastream
@@ -37,6 +37,7 @@
false
fi
else
+
pamFile="/etc/pam.d/password-auth"
if grep -q "rounds=" $pamFile; then |
a69381b to
174ced7
Compare
- Add initial version of the anssi_bp28_minmal.profile, after covering the whole profile, will use reference to the common definition in controls/anssi.yml - Enable sle15 platform for ANSSI needed rules - Also add CCE identifiers where needed - Add missing rules to ANSSI minimal profile for SLE15 - Add SLE15 CCE ids to ANSSI rules in minimal profile - Enable Bash and Ansible remediations for accounts_password_minlen_login_defs rule - Enable Bash and Ansible remediations for accounts_password_pam_unix_rounds_system_auth - Enable Bash and Ansible remediations for dnf-automatic_apply_updates rule - Add rule accounts_password_pam_unix_rounds_password_auth remediations support for SLE - Use SLE specific gpgkey rule - Restructure ANSSI SLE15 minimal profile definition - Fix ANSSI profiles referencing
cffdd09 to
c048ed6
Compare
|
/ok-to-test |
Description:
Rationale: