Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small user testing issues #1607

Merged
merged 2 commits into from Mar 22, 2019

Conversation

Projects
None yet
2 participants
@SaraVieira
Copy link
Collaborator

SaraVieira commented Mar 18, 2019

Fixes three small things that confused a user

  • Carousel now goes around when you click next in the last sandbox
  • The text in custom vscodeTheme is now a placeholder
  • Text at the top for renaming a sandbox is a placeholder if the name is not set yet. otherwhise it's the value

@SaraVieira SaraVieira requested a review from CompuIves Mar 18, 2019

@CompuIves

This comment has been minimized.

Copy link
Owner

CompuIves commented Mar 22, 2019

Very nice!

@CompuIves CompuIves merged commit 3917050 into master Mar 22, 2019

16 of 19 checks passed

continous-deployment/pr Deployment error
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: build-dependencies CircleCI is running your tests
Details
security/snyk - package.json (CompuIves) No manifest changes detected
security/snyk - packages/app/package.json (CompuIves) No manifest changes detected
security/snyk - packages/codesandbox-api/package.json (CompuIves) No manifest changes detected
security/snyk - packages/common/package.json (CompuIves) No manifest changes detected
security/snyk - packages/homepage/package.json (CompuIves) No manifest changes detected
security/snyk - packages/node-services/package.json (CompuIves) No manifest changes detected
security/snyk - packages/react-embed/package.json (CompuIves) No manifest changes detected
security/snyk - packages/react-sandpack/package.json (CompuIves) No manifest changes detected
security/snyk - packages/sandbox-hooks/package.json (CompuIves) No manifest changes detected
security/snyk - packages/sandpack/package.json (CompuIves) No manifest changes detected
security/snyk - packages/sse-hooks/package.json (CompuIves) No manifest changes detected
security/snyk - standalone-packages/codesandbox-browserfs/package.json (CompuIves) No manifest changes detected
security/snyk - standalone-packages/monaco-editor/package.json (CompuIves) No manifest changes detected
security/snyk - standalone-packages/monaco-typescript/package.json (CompuIves) No manifest changes detected
security/snyk - standalone-packages/sse-loading-screen/package.json (CompuIves) No manifest changes detected
security/snyk - standalone-packages/vscode-editor/package.json (CompuIves) No manifest changes detected

@SaraVieira SaraVieira deleted the placeholders branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.