New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction example #619

Merged
merged 15 commits into from Sep 5, 2018

Conversation

@kloppstock
Contributor

kloppstock commented Aug 27, 2018

This adds an optimized reduction to the examples folder.

kloppstock added some commits Aug 27, 2018

@ax3l ax3l added the example label Aug 27, 2018

@ax3l ax3l requested a review from BenjaminW3 Aug 27, 2018

@ax3l ax3l added this to the Version 0.4.0 milestone Aug 27, 2018

@BenjaminW3

This comment has been minimized.

Show comment
Hide comment
@BenjaminW3

BenjaminW3 Aug 28, 2018

Member

Thank you very much for this example. I will do a real review after it is successfully compiling.
If you do not have the time to fix it, I can do it as well.

Member

BenjaminW3 commented Aug 28, 2018

Thank you very much for this example. I will do a real review after it is successfully compiling.
If you do not have the time to fix it, I can do it as well.

kloppstock added some commits Aug 28, 2018

//! \param data A pointer to the data.
//! \param linearizedIndex The linearized index.
//! \param gridSize The grid size.
//! \param n The problem size.

This comment has been minimized.

@sbastrakov

sbastrakov Aug 28, 2018

Member

The comment does not fully match the function parameters (probably was not updated)

@sbastrakov

sbastrakov Aug 28, 2018

Member

The comment does not fully match the function parameters (probably was not updated)

Show outdated Hide outdated example/reduce/src/iterator.hpp Outdated
Show outdated Hide outdated example/reduce/src/iterator.hpp Outdated
@BenjaminW3

This comment has been minimized.

Show comment
Hide comment
@BenjaminW3

BenjaminW3 Sep 3, 2018

Member

Please ignore the Windows CI errors. They will be fixed in my PR.

Member

BenjaminW3 commented Sep 3, 2018

Please ignore the Windows CI errors. They will be fixed in my PR.

@BenjaminW3 BenjaminW3 merged commit 4c1e882 into ComputationalRadiationPhysics:develop Sep 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment