Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize the Dockerfile halts the container #32

Closed
gmaron opened this issue Aug 30, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@gmaron
Copy link

commented Aug 30, 2017

Hi everyone,

I have this Dockerfile

FROM consol/ubuntu-xfce-vnc:latest

MAINTAINER Gaston Maron "gastonmaron@gmail.com"
ENV REFRESHED_AT 2017-08-30

USER 0

RUN apt-get update && apt-get -y upgrade \
    && apt-get install -y build-essential \
    && apt-get install -y nano \
    && apt-get install -y net-tools \
    && apt-get install -y software-properties-common \
    && add-apt-repository -y ppa:openjdk-r/ppa \
    && apt-get update \
    && apt-get install -y openjdk-7-jdk

USER 1984

ENTRYPOINT ["/dockerstartup/vnc_startup.sh"]

and when I try to run the image, the container halts itself.

The log file

------------------ VNC environment started ------------------

VNCSERVER started on DISPLAY= :1 
	=> connect via VNC viewer with 172.17.0.4:5901

noVNC HTML client started:
	=> connect via http://172.17.0.4:6901/?password=...

...

(xfwm4:117): libxfce4ui-WARNING **: ICE I/O Error

(xfwm4:117): libxfce4ui-WARNING **: Disconnected from session manager.

(xfsettingsd:132): libxfce4ui-WARNING **: ICE I/O Error


(xfsettingsd:132): libxfce4ui-WARNING **: Disconnected from session manager.

Do you know what is the problem here?

Thanks!

@toschneck

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2017

I currently tested it on my machine. And the Problem is, that you overwrite the entrypoint. If I remove the last line of your example all is working. I don't know why this is happening, but it solves the Problem 😉 @gmaron can you verfiy this?

@gmaron

This comment has been minimized.

Copy link
Author

commented Aug 31, 2017

Thank you so much for your help!

It was the point. I think you should update your README to avoid this 'little' bug.

Have a nice day!

@gmaron gmaron closed this Aug 31, 2017

@ghost ghost removed the TO REVIEW label Aug 31, 2017

@toschneck

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2017

@gmaron

This comment has been minimized.

Copy link
Author

commented Aug 31, 2017

Yes, the documentation is very complete and updated. But at that point, at least for me, it generated confusion. Whatever, the problem is solved.

Thanks @toschneck !

@rbo

This comment has been minimized.

Copy link

commented Sep 1, 2017

The main problem is, if you overwrite the ENTRYPOINT it "delete" the CMD from the base image. unfortunately...

For example:

$ docker inspect  consol/ubuntu-xfce-vnc:latest | jq '.[] | { Entrypoint: .Config.Entrypoint, Cmd: .Config.Cmd}'
{
 "Entrypoint": [
   "/dockerstartup/vnc_startup.sh"
 ],
 "Cmd": [
   "--tail-log"
 ]
}

$ cat Dockerfile
FROM consol/ubuntu-xfce-vnc:latest
ENTRYPOINT ["/dockerstartup/vnc_startup.sh"]

$ docker build .
Sending build context to Docker daemon 2.048 kB
Step 1 : FROM consol/ubuntu-xfce-vnc:latest
---> 2af76cf39a98
Step 2 : ENTRYPOINT /dockerstartup/vnc_startup.sh
---> Using cache
---> a245e11f8d7d
Successfully built a245e11f8d7d

$ docker inspect  a245e11f8d7d | jq '.[] | { Entrypoint: .Config.Entrypoint, Cmd: .Config.Cmd}'
{
 "Entrypoint": [
   "/dockerstartup/vnc_startup.sh"
 ],
 "Cmd": null
}

From my opinion of view we should adjust consol/ubuntu-xfce-vnc to work with an empty CMD.

@rbo rbo reopened this Sep 1, 2017

@toschneck

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2017

@rbo should be fixed now, see next docker build with tag :dev. Can you close the issue after reviewing?

@rbo

This comment has been minimized.

Copy link

commented Sep 1, 2017

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.