Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite scroll bug #9

Open
tplusrex opened this issue May 16, 2017 · 1 comment
Open

Infinite scroll bug #9

tplusrex opened this issue May 16, 2017 · 1 comment

Comments

@tplusrex
Copy link

tplusrex commented May 16, 2017

Cause

The problem was introduced with this line. Calculations doesn't support infinite scroll.
https://github.com/akiran/react-slick/blob/master/src/mixins/event-handlers.js#L27

Effect

When lazy loading an infinite slide the last slide does not transition right instead it transitions left. You are moved to the first slide but for infinite galleries the first slide is appended to the right of the last allowing for the infinite illusion to be seamless.

The issue is animated well here.
akiran#698

Proposed Solution

Exclude infinite galleries from the condition. This allows infinite galleries with lazy loading to use the basic calculation.

@gkilian
Copy link
Collaborator

gkilian commented May 18, 2017

Fixed with #8

Leaving issue open until upstreamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants