From eb57231877649630ff85e038ca8135e0756e094b Mon Sep 17 00:00:00 2001
From: Konstantinos Kopanidis <kkopanidis@users.noreply.github.com>
Date: Fri, 26 Aug 2022 17:56:14 +0300
Subject: [PATCH] fix(sms): not starting up with invalid config (#294)

---
 modules/sms/src/Sms.ts | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/modules/sms/src/Sms.ts b/modules/sms/src/Sms.ts
index d9f2e0ef5..23f7df8c8 100644
--- a/modules/sms/src/Sms.ts
+++ b/modules/sms/src/Sms.ts
@@ -69,9 +69,6 @@ export default class Sms extends ManagedModule<Config> {
       this.updateHealth(HealthCheckStatus.NOT_SERVING);
     } else {
       await this.initProvider();
-      this.adminRouter.updateProvider(this._provider!);
-      this.isRunning = true;
-      this.updateHealth(HealthCheckStatus.SERVING);
     }
   }
 
@@ -81,11 +78,21 @@ export default class Sms extends ManagedModule<Config> {
     const settings = smsConfig[name];
 
     if (name === 'twilio') {
-      this._provider = new TwilioProvider(settings);
+      try {
+        this._provider = new TwilioProvider(settings);
+      } catch (e) {
+        this._provider = undefined;
+        this.updateHealth(HealthCheckStatus.NOT_SERVING);
+        ConduitGrpcSdk.Logger.error(e as Error);
+        return;
+      }
     } else {
       ConduitGrpcSdk.Logger.error('SMS provider not supported');
-      process.exit(-1);
+      return;
     }
+    this.adminRouter.updateProvider(this._provider!);
+    this.isRunning = true;
+    this.updateHealth(HealthCheckStatus.SERVING);
   }
 
   // gRPC Service