Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find logical ref resource for #112

Closed
bboure opened this issue Apr 24, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@bboure
Copy link
Collaborator

commented Apr 24, 2019

@lightsofapollo

Since #65 was merged I get this kind of error all over the place.

Error: Unable to find logical ref resource for : AWS::Cognito::UserPool (custom.appSync.userPoolConfig.userPoolId.Ref)

The reason is that the implementation only supports DynamoDb resolution for now and throws an exception on any other resource.

This is a breaking change. Before this, userPoolId being a reference did not cause any problem since the emulator simply ignores/mocks authentication.

This error also occurs in any other resource referencing another, even if not even related to AppSync at all.

I suggest we change this line to fallback to the previous behaviour and simply return value untouched/unresolved, instead of throwing an exception.

@pianomansam

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@lightsofapollo

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@pianomansam This should be fixed in 0.12 onward. Can you confirm this works for you?

@pianomansam

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

@lightsofapollo this appears to be fixed on 0.12

@cbaron cbaron closed this May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.