Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cfRef Resolver #113

Merged
merged 4 commits into from Apr 30, 2019

Conversation

Projects
None yet
4 participants
@bboure
Copy link
Collaborator

commented Apr 24, 2019

@lightsofapollo as discussed in #112
This fixes my issue

@pianomansam

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

I've confirmed that using this fix on the fix-Ref-resolver branch also resolves the issue for me.

@cbaron

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

I don't have much context on this issue, but LGTM.

@bboure bboure requested a review from lightsofapollo Apr 26, 2019

@bboure

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 26, 2019

I had more issue because of the other Exceptions
I think I would remove them all and just return value in those cases.

bboure added some commits Apr 26, 2019

@lightsofapollo

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Nice thank you for the fix

@lightsofapollo

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

@bboure Can you update the test checking for this and potentially add a test with the case that effected you? I want to make sure we do not regress this behavior.

@lightsofapollo
Copy link
Contributor

left a comment

Minor ask and suggestion.

@bboure

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 26, 2019

@lightsofapollo I added test based on my use case.

@lightsofapollo

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@bboure Looks good to me! Ship it!

@bboure bboure merged commit 733b9ab into master Apr 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bboure bboure deleted the fix-Ref-resolver branch Apr 30, 2019

@bboure

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 30, 2019

merged and version bumped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.