Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use a different property name for images #29

Conversation

3 participants
@gisostallenberg
Copy link
Member

commented Jun 5, 2019

This will allow to use the block as

{% include '@ConnectHollandSuluBlock/html5/parts/images.html.twig' with {block_property: 'myOwnProperty'} %}
Allow to use a different property name for images
This will allow to use the block as
```twig
{% include '@ConnectHollandSuluBlock/html5/parts/images.html.twig' with {block_property: 'myOwnProperty'} %}
```

@gisostallenberg gisostallenberg requested review from reyostallenberg and guuse Jun 5, 2019

@guuse

guuse approved these changes Jun 5, 2019

@reyostallenberg
Copy link
Member

left a comment

Could you also always leave the classname images

@gisostallenberg gisostallenberg requested a review from reyostallenberg Jun 5, 2019

@gisostallenberg gisostallenberg merged commit e755612 into ConnectHolland:master Jun 5, 2019

1 check passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.