Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and corrections #2

Conversation

@reyostallenberg
Copy link
Member

commented Oct 2, 2019

No description provided.

@reyostallenberg reyostallenberg requested a review from gisostallenberg Oct 2, 2019
public function getConfigTreeBuilder()
{
$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('connectholland_user');

This comment has been minimized.

Copy link
@gisostallenberg

gisostallenberg Oct 2, 2019

Member

You might want to fix this for Sf 4.2, to avoid deprecation notices

This comment has been minimized.

Copy link
@reyostallenberg

reyostallenberg Oct 2, 2019

Author Member

Yes

$configuration = new Configuration();
$config = $this->processConfiguration($configuration, $configs);
Comment for lines +21  – +22

This comment has been minimized.

Copy link
@gisostallenberg

gisostallenberg Oct 2, 2019

Member

Is this code required? Nothing is done with it.

This comment has been minimized.

Copy link
@reyostallenberg

reyostallenberg Oct 2, 2019

Author Member

I think not

@reyostallenberg reyostallenberg merged commit c89e2b9 into ConnectHolland:master Oct 2, 2019
@reyostallenberg reyostallenberg deleted the reyostallenberg:cleanup-and-corrections branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.