Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sf3.4 compatibility #5

Merged

Conversation

@reyostallenberg
Copy link
Member

commented Oct 3, 2019

No description provided.

$this->mailer = $mailer;
$this->fromEmail = $fromEmail;
$this->twig = $twig;
$this->projectDirectory = $projectDirectory;

This comment has been minimized.

Copy link
@gisostallenberg

gisostallenberg Oct 3, 2019

Member

The projectDirectory is not used

Suggested change
$this->projectDirectory = $projectDirectory;
- '@mailer'
- '%env(USERBUNDLE_FROM_EMAILADDRESS)%'
- '@twig'
- '%kernel.project_dir%'

This comment has been minimized.

Copy link
@gisostallenberg

gisostallenberg Oct 3, 2019

Member

This is not used in the class

Suggested change
- '%kernel.project_dir%'
@reyostallenberg reyostallenberg merged commit 9b0207d into ConnectHolland:master Oct 7, 2019
@reyostallenberg reyostallenberg deleted the reyostallenberg:sf3.4-compatibility branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.