Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5 Loading with Plugin objects #15

Merged
merged 7 commits into from Aug 1, 2019

Conversation

@o0h
Copy link
Collaborator

o0h commented Aug 1, 2019

Fix #5

  1. Create plugin class and bootstrap/load middleware in there.
  2. Simplify loading middleware.
o0h added 7 commits Jul 22, 2019
Describe Plugin object loading.
Remove two.
1. To check if Application class exists
2. Unnecessary trap for throwing of MiddlewareQueue::insertAfter's LogicException
@o0h o0h added this to the 2.0 milestone Aug 1, 2019
@o0h o0h added the enhancement label Aug 1, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #15 into 2.x will increase coverage by 1.62%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x      #15      +/-   ##
============================================
+ Coverage     75.29%   76.92%   +1.62%     
- Complexity       36       37       +1     
============================================
  Files             4        5       +1     
  Lines            85       91       +6     
============================================
+ Hits             64       70       +6     
  Misses           21       21
Impacted Files Coverage Δ Complexity Δ
src/Plugin.php 100% <100%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0234e...374f8e6. Read the comment docs.

@o0h o0h merged commit c59e1d4 into Connehito:2.x Aug 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@o0h o0h deleted the o0h:5-cake36-plugin-object-auto-load-middleware branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.