Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sentry sdk to 2x #17

Merged
merged 8 commits into from Nov 16, 2019
Merged

Upgrade sentry sdk to 2x #17

merged 8 commits into from Nov 16, 2019

Conversation

@o0h
Copy link
Collaborator

o0h commented Nov 4, 2019

ref: #10
see:

work on..

  • update sentry/sentry to 2.x
    • check min php-ver
  • update Client class
  • testing
  • update readme
@o0h o0h self-assigned this Nov 4, 2019
@o0h o0h force-pushed the o0h:upgrade-sentry-sdk-to-2x branch from a306550 to 3aafabd Nov 4, 2019
@o0h o0h force-pushed the o0h:upgrade-sentry-sdk-to-2x branch from 3aafabd to 89765fc Nov 4, 2019
@o0h o0h force-pushed the o0h:upgrade-sentry-sdk-to-2x branch from 435d9bf to 1fc66f6 Nov 16, 2019
@o0h o0h force-pushed the o0h:upgrade-sentry-sdk-to-2x branch from 1fc66f6 to 3bcc23f Nov 16, 2019
@o0h o0h force-pushed the o0h:upgrade-sentry-sdk-to-2x branch from 3bcc23f to 2d96df0 Nov 16, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #17 into 2.x will increase coverage by 8.26%.
The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x      #17      +/-   ##
============================================
+ Coverage     76.92%   85.18%   +8.26%     
+ Complexity       37       26      -11     
============================================
  Files             5        5              
  Lines            91       81      -10     
============================================
- Hits             70       69       -1     
+ Misses           21       12       -9
Impacted Files Coverage Δ Complexity Δ
src/Http/Client.php 86.36% <90.9%> (+14.14%) 12 <9> (-11) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c89e4...2d96df0. Read the comment docs.

@o0h o0h changed the title Upgrade sentry sdk to 2x [VERY WIP] Upgrade sentry sdk to 2x Nov 16, 2019
@o0h o0h merged commit 1c55781 into Connehito:2.x Nov 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@o0h o0h deleted the o0h:upgrade-sentry-sdk-to-2x branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.