Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] eth-crypto incompatible with react-native #677

Closed
pedrouid opened this issue Jan 6, 2020 · 0 comments · Fixed by #678
Closed

[client] eth-crypto incompatible with react-native #677

pedrouid opened this issue Jan 6, 2020 · 0 comments · Fixed by #678

Comments

@pedrouid
Copy link
Member

@pedrouid pedrouid commented Jan 6, 2020

Currently eth-crypto has a WebCrypto API incompatibility with react-native. This could be solved by porting the specific methods and use the eccrypto dependency independently

To make sure it works with React-Native, this issue depends on the following PR from eccrypto:
bitchan/eccrypto#50

However can be added to a postinstall script to apply the fix as follows:

TARGET="node_modules/eccrypto/browser.js"
sed -i'' -e "s/typeof window === 'undefined'/typeof browserCrypto === 'undefined' || typeof browserCrypto.getRandomValues === 'undefined'/" $TARGET;
@pedrouid pedrouid added this to To do in Sprint Task Workboard via automation Jan 6, 2020
@pedrouid pedrouid moved this from To do to Pending Review in Sprint Task Workboard Jan 6, 2020
@bohendo bohendo closed this in #678 Jan 7, 2020
Sprint Task Workboard automation moved this from Pending Review to Done (Merged or Closed, not yet added to Release Notes) Jan 7, 2020
@bohendo bohendo removed this from Done (Merged or Closed, not yet added to Release Notes) in Sprint Task Workboard Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.