Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eth-crypto with eccrypto #674

Closed
wants to merge 3 commits into from
Closed

Replace eth-crypto with eccrypto #674

wants to merge 3 commits into from

Conversation

@pedrouid
Copy link
Member

pedrouid commented Jan 3, 2020

Ensuring it works with React-Native depends on the following PR from eccrypto:
bitchan/eccrypto#50

However can be added to a postinstall script as follows:

TARGET="node_modules/eccrypto/browser.js"
sed -i'' -e "s/typeof window === 'undefined'/typeof browserCrypto === 'undefined' || typeof browserCrypto.getRandomValues === 'undefined'/" $TARGET;
pedrouid and others added 3 commits Jan 3, 2020
@todo-tracker

This comment has been minimized.

Copy link

todo-tracker bot commented Jan 6, 2020

Hey, bohendo

We noticed you made changes to a file with a TODO on it.
These are set to make sure potential Technical Debt doesn't get forgotten.
While you're here take a shot at turning a listed TODO into a TODONE!

Id Name File Priority
77 how do we know if we're in prod mode or not? ops/test-integration.sh Normal

button

@pedrouid

This comment has been minimized.

Copy link
Member Author

pedrouid commented Jan 6, 2020

replaced by #678

@pedrouid pedrouid closed this Jan 6, 2020
@pedrouid pedrouid deleted the replace-eth-crypto branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.