Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pre balances #723

Merged
merged 2 commits into from Jan 13, 2020
Merged

fix pre balances #723

merged 2 commits into from Jan 13, 2020

Conversation

@pedrouid
Copy link
Member

pedrouid commented Jan 13, 2020

The Problem

The Solution

Checklist:

  • I am making this PR against staging, not master
  • My code follows the code style of this project.
  • I have described any backwards-incompatibility implications above.
  • I have highlighted which parts of the code should be reviewed most carefully.
  • If my change requires a change to the documentation, I have updated it accordingly.
pedrouid added 2 commits Jan 13, 2020
Copy link
Contributor

LayneHaber left a comment

No qualms with merging these into the 703-channel-provider-tests without the CD/CI passing

@pedrouid

This comment has been minimized.

Copy link
Member Author

pedrouid commented Jan 13, 2020

No qualms with merging these into the 703-channel-provider-tests without the CD/CI passing

Yeah I know, I was just having issues with testing locally so I was using CI as a test bench

@pedrouid pedrouid merged commit 3e9c3c5 into 703-channelProvider-tests Jan 13, 2020
10 of 12 checks passed
10 of 12 checks passed
build
Details
test-cf
Details
test-cf
Details
test-client
Details
test-integration test-integration
Details
test-client
Details
test-node
Details
test-integration test-integration
Details
test-backwards-compatibility
Details
test-bot
Details
test-bot-farm
Details
test-daicard
Details
@pedrouid pedrouid deleted the refactor-test-runner branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.