Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor eth signMessage #828

Closed
wants to merge 4 commits into from
Closed

refactor eth signMessage #828

wants to merge 4 commits into from

Conversation

@pedrouid
Copy link
Member

pedrouid commented Feb 11, 2020

Replacing ethers.js signMessage with eccrypto-js signing

@todo-tracker

This comment has been minimized.

Copy link

todo-tracker bot commented Feb 11, 2020

Hey, pedrouid

We noticed you made changes to a file with a TODO on it.
These are set to make sure potential Technical Debt doesn't get forgotten.
While you're here take a shot at turning a listed TODO into a TODONE!

Id Name File Priority
86 clean up types from restore, without the any typing things modules/client/src/channelProvider.ts Normal
87 remove when using only store package modules/client/src/channelProvider.ts Normal

button

pedrouid added 3 commits Feb 12, 2020
…into refactor-eth-sign
…into refactor-eth-sign
…into refactor-eth-sign
@pedrouid

This comment has been minimized.

Copy link
Member Author

pedrouid commented Feb 12, 2020

replaced by #830

@pedrouid pedrouid closed this Feb 12, 2020
@pedrouid pedrouid deleted the refactor-eth-sign branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.