Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Crypto module #830

Merged
merged 46 commits into from Feb 18, 2020
Merged

add Crypto module #830

merged 46 commits into from Feb 18, 2020

Conversation

@pedrouid
Copy link
Member

pedrouid commented Feb 12, 2020

  • replace eccrypto with eccrypto-js
  • replace ethers.js signing with eccrypto-js signing
  • move crypto utils into its own module
pedrouid added 19 commits Feb 10, 2020
…into refactor-eth-sign
@todo-tracker

This comment has been minimized.

Copy link

todo-tracker bot commented Feb 12, 2020

Hey, pedrouid

We noticed you made changes to a file with a TODO on it.
These are set to make sure potential Technical Debt doesn't get forgotten.
While you're here take a shot at turning a listed TODO into a TODONE!

Id Name File Priority
79 if this fails for ANY REASON, uninstall the app to make sure that modules/client/src/controllers/ConditionalTransferController.ts Normal
80 if this fails for ANY REASON, uninstall the app to make sure that modules/client/src/controllers/ConditionalTransferController.ts Normal
86 clean up types from restore, without the any typing things modules/client/src/channelProvider.ts Normal
87 remove when using only store package modules/client/src/channelProvider.ts Normal

button

@pedrouid pedrouid changed the base branch from refactor-eth-sign to staging Feb 12, 2020
pedrouid added 5 commits Feb 12, 2020
@todo-tracker

This comment has been minimized.

Copy link

todo-tracker bot commented Feb 13, 2020

Hey, pedrouid

It looks like you made some changes to this pull request!
These changes included files that have a TODO linked to them.
Click the button below to view details on all the TODO for this pull request, and while you're here take a shot at turning a TODO into a TODONE!

Id Name File Priority
101 move this to install modules/node/src/appRegistry/appRegistry.service.ts Normal
102 this doesn't work with the new paradigm, we won't know this info modules/node/src/appRegistry/appRegistry.service.ts Normal

button

pedrouid added 2 commits Feb 13, 2020
@todo-tracker

This comment has been minimized.

Copy link

todo-tracker bot commented Feb 17, 2020

Hey, pedrouid

It looks like you made some changes to this pull request!
These changes included files that have a TODO linked to them.
Click the button below to view details on all the TODO for this pull request, and while you're here take a shot at turning a TODO into a TODONE!

Id Name File Priority
64 expose remove listener modules/node/src/transfer/transfer.service.ts Normal
68 rename to "get" when in branch to publish new client modules/node/src/transfer/transfer.provider.ts Normal
71 merge: modules/client/src/node.ts Normal
92 merge these? modules/types/src/events.ts Normal

button

pedrouid added 8 commits Feb 17, 2020
@todo-tracker

This comment has been minimized.

Copy link

todo-tracker bot commented Feb 18, 2020

Hey, bohendo

It looks like you made some changes to this pull request!
These changes included files that have a TODO linked to them.
Click the button below to view details on all the TODO for this pull request, and while you're here take a shot at turning a TODO into a TODONE!

Id Name File Priority
66 determine virtual app in a more resilient way modules/client/src/listener.ts Normal
70 make this actually activate wallet connect cypress/tests/utils.js Normal
90 Don't export contract dependencies or ones only used for testing? modules/contracts/index.ts Normal

button

@todo-tracker

This comment has been minimized.

Copy link

todo-tracker bot commented Feb 18, 2020

Hey, bohendo

It looks like you made some changes to this pull request!
These changes included files that have a TODO linked to them.
Click the button below to view details on all the TODO for this pull request, and while you're here take a shot at turning a TODO into a TODONE!

Id Name File Priority
59 no way to determine if this is a virtual or regular app being modules/cf-core/src/methods/app-instance/propose-install/controller.ts Normal
60 no way to determine if this is a virtual or regular app being modules/cf-core/src/methods/app-instance/propose-install/controller.ts Normal
61 no way to determine if this is a virtual or regular app being modules/cf-core/src/methods/app-instance/propose-install/controller.ts Normal
62 no way to determine if this is a virtual or regular app being modules/cf-core/src/methods/app-instance/propose-install/operation.ts Normal
63 remove if store is added to Context type modules/cf-core/src/store.ts Normal
69 import from connext/types modules/dashboard/src/lib/messaging.js Normal
81 dont listen to linked transfer app in default listener, only modules/client/src/controllers/ResolveConditionController.ts Normal
82 how can we access / verify the meta here? modules/client/src/controllers/ResolveConditionController.ts Normal
83 should add once to top level client modules/test-runner/src/util/helpers/fundChannel.ts Normal
84 Currently, this test always fails because when promise is never rejected when modules/test-runner/src/swap/swap.test.ts Normal
85 events for withdrawal commitments! issue 698 modules/test-runner/src/withdraw/withdraw.test.ts Normal
89 memoize? modules/cf-core/src/utils.ts Normal
95 remove modules/client/src/controllers/ResolveConditionController.ts Normal
96 remove modules/client/src/controllers/ResolveConditionController.ts Normal
97 remove modules/client/src/controllers/ResolveConditionController.ts Normal
98 this passes locally when running `make test-integration, and when modules/test-runner/src/swap/swap.test.ts Normal
99 should the intermediary have sufficient funds modules/cf-core/src/protocol/install-virtual-app.ts Normal

button

@bohendo bohendo merged commit 8a58ca8 into staging Feb 18, 2020
12 checks passed
12 checks passed
build
Details
test-cf
Details
test-cf
Details
test-client
Details
test-client
Details
test-contracts
Details
test-contracts
Details
test-integration
Details
test-node
Details
test-integration
Details
test-backwards-compatibility
Details
test-daicard
Details
@bohendo bohendo deleted the crypto-module branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.