Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve crypto module signing and recovery with tests #907

Merged
merged 11 commits into from Mar 21, 2020

Conversation

@pedrouid
Copy link
Member

pedrouid commented Mar 19, 2020

The Problem

The Solution

Checklist:

  • I am making this PR against staging, not master
  • My code follows the code style of this project.
  • I have described any backwards-incompatibility implications above.
  • I have highlighted which parts of the code should be reviewed most carefully.
  • If my change requires a change to the documentation, I have updated it accordingly.
modules/client/src/channelProvider.ts Outdated Show resolved Hide resolved
pedrouid added 8 commits Mar 19, 2020
fix
@pedrouid pedrouid merged commit 0cc8690 into staging Mar 21, 2020
11 of 12 checks passed
11 of 12 checks passed
build
Details
test-cf
Details
test-cf
Details
test-client
Details
test-client
Details
test-contracts
Details
test-contracts
Details
test-integration
Details
test-node
Details
test-integration
Details
test-backwards-compatibility test-backwards-compatibility
Details
test-daicard
Details
@pedrouid pedrouid deleted the signing-and-recovery branch Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.