Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace signDigestWithEthers with signDigest from crypto module + other improvements #910

Merged
merged 43 commits into from Mar 26, 2020

Conversation

@pedrouid
Copy link
Member

pedrouid commented Mar 22, 2020

requires #914

pedrouid added 2 commits Mar 22, 2020
@pedrouid pedrouid changed the title Replace signDigest from ethers with crypto module Signing Refactor - Replace signDigest from ethers with crypto module Mar 22, 2020
pedrouid added 2 commits Mar 22, 2020
…indra into refactor-signing-new
…indra into refactor-signing-new
@pedrouid pedrouid changed the base branch from refactor-signing to staging Mar 23, 2020
@pedrouid pedrouid force-pushed the refactor-signing-new branch from 3f4951a to 2bf5967 Mar 23, 2020
@pedrouid pedrouid changed the base branch from staging to refactor-signing Mar 23, 2020
@pedrouid pedrouid changed the title Signing Refactor - Replace signDigest from ethers with crypto module (2) Signing Refactor - Replace signDigest from ethers with crypto module Mar 23, 2020
pedrouid added 16 commits Mar 23, 2020
…indra into refactor-signing-new
…ect/indra into refactor-signing-async-recovery
…indra into refactor-signing-new
modules/cf-core/src/store_.ts Outdated Show resolved Hide resolved
LayneHaber and others added 4 commits Mar 25, 2020
@pedrouid pedrouid changed the base branch from refactor-signing to staging Mar 25, 2020
pedrouid added 2 commits Mar 25, 2020
…covery

(3) Signing Refactor - Refactor crypto tests and make recoverAddress async
@pedrouid pedrouid changed the title (2) Signing Refactor - Replace signDigest from ethers with crypto module Replace signDigestWithEthers with signDigest from crypto module + other improvements Mar 25, 2020
LayneHaber added 10 commits Mar 25, 2020
15s to 20s
@LayneHaber LayneHaber merged commit c35f6da into staging Mar 26, 2020
13 of 14 checks passed
13 of 14 checks passed
build
Details
test-cf
Details
test-cf
Details
test-client
Details
test-client
Details
test-contracts
Details
test-contracts
Details
test-crypto
Details
test-crypto
Details
test-integration
Details
test-node
Details
test-integration
Details
test-backwards-compatibility test-backwards-compatibility
Details
test-daicard
Details
@pedrouid pedrouid deleted the refactor-signing-new branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.