Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use global localStorage and lazy load it #919

Merged
merged 1 commit into from Mar 24, 2020
Merged

use global localStorage and lazy load it #919

merged 1 commit into from Mar 24, 2020

Conversation

@pedrouid
Copy link
Member

pedrouid commented Mar 24, 2020

Quick fix for 6.0.0-alpha.0

Error: Cannot find module 'localStorage'
@pedrouid

This comment has been minimized.

Copy link
Member Author

pedrouid commented Mar 24, 2020

We should test this on the daicard before merging

@LayneHaber LayneHaber self-requested a review Mar 24, 2020
Copy link
Contributor

LayneHaber left a comment

Tested out on daicard, seems to work! Will merge + publish new alpha version once CD/CI finishes

@LayneHaber LayneHaber merged commit 37409b7 into staging Mar 24, 2020
11 of 12 checks passed
11 of 12 checks passed
build
Details
test-cf
Details
test-cf
Details
test-client
Details
test-client
Details
test-contracts
Details
test-contracts
Details
test-integration
Details
test-node
Details
test-integration
Details
test-backwards-compatibility test-backwards-compatibility
Details
test-daicard
Details
@LayneHaber LayneHaber deleted the fix-localstorage branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.