Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is non-deterministic, CSS changes on every build #37

Closed
markdalgleish opened this issue Apr 19, 2015 · 1 comment
Closed

Build is non-deterministic, CSS changes on every build #37

markdalgleish opened this issue Apr 19, 2015 · 1 comment

Comments

@markdalgleish
Copy link
Contributor

@markdalgleish markdalgleish commented Apr 19, 2015

The random animation delays (e.g.

animation-delay: ((random(100) / 100) - 0.2) + s;
animation-duration: ((random(100) / 100) + 0.3) + s;
) are only calculated at build time and make the build non-deterministic.

Every build results in a different CSS file, which is probably not ideal for a number of reasons:

  • A refactor with no change to the resulting CSS will still generate new animations.
  • Random animations are locked for each version, so users of an app using this library will see the same "random" animation for a while until they upgrade, at which point they'll get a new "random" animation until the next upgrade.

If you don't see this as a problem, feel free to close this issue.

@ConnorAtherton

This comment has been minimized.

Copy link
Owner

@ConnorAtherton ConnorAtherton commented Apr 20, 2015

Yeah, I'm not entirely happy with this behaviour. It wasn't a big issue for me at the start because I was just having fun with it and seeing what interesting animations I could create under imposed constraints.

I think if the parameters that generate the randomness are bounded in such a way that it doesn't change the output enough for people to visually notice, then I don't see it as a problem.

However, I've never been entirely comfortable with values changing for no reason just from a maintenance standpoint. I want to keep this open and replace the random calls to verbose nth-child declarations.

p.s. How did you get involved in nodeschool? I would love find a way to help out in my spare time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.