This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Display all migration gas numbers in dec and hex formats - #2916
Merged
Conversation
closes #2799 - Add decAndHex(num) utlity function that displays a number as decimal with hex in parenthesis - Use this utility in all migration messages that print gas
gnidan
requested review from
eggplantzzz and
mikeseese
and removed request for
mikeseese
March 26, 2020 16:52
gnidan
approved these changes
Mar 26, 2020
gnidan
left a comment
gnidan
left a comment
Contributor
There was a problem hiding this comment.
Neat @rkalis! @eggplantzzz what do you think of this?
CruzMolina
reviewed
Apr 2, 2020
Contributor
Author
|
@CruzMolina It should be in gas units. wei/gwei only come into play once you have to pay for the gas, which is unrelated to the limit or the amount of gas sent. Unless I'm misunderstanding what you mean? |
Contributor
|
People have had enough time if they wanted to object to this :) I'm merging. Thanks again @rkalis ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2799
decAndHex(num)utlity function that displays a number as decimal with hex in parenthesisI wasn't sure what the versioning process is, so I left the versions as is. But since the dependencies are
coredepends onmigratedepends onreporters, bothreportersandmigrateneed a version bump to be included in core.