Add ability to disable BLS verification for fuzzing #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminion
reviewed
Jul 16, 2020
|
Hey @cemozerr! |
Nashatyrev
reviewed
Jul 16, 2020
ethereum/core/src/main/java/tech/pegasys/teku/core/blockvalidator/BatchSignatureVerifier.java
Outdated
Show resolved
Hide resolved
benjaminion
reviewed
Jul 16, 2020
|
BTW do you think it makes sense to have a hidden command line option to disable verification? I regularly disable verification by modifying the code to speed up sync when debugging |
Nashatyrev
reviewed
Jul 16, 2020
Nashatyrev
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR Description
Adds the ability to disable BLS verification for fuzzing.
Fixed Issue(s)
Fixes #1958
Documentation
documentationlabel to this PR if updates are required.