Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable BLS verification for fuzzing #2363

Merged
merged 9 commits into from Jul 16, 2020

Conversation

cemozerr
Copy link
Contributor

@cemozerr cemozerr commented Jul 16, 2020

PR Description

Adds the ability to disable BLS verification for fuzzing.

Fixed Issue(s)

Fixes #1958

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

bls/build.gradle Outdated Show resolved Hide resolved
@Nashatyrev
Copy link
Contributor

Hey @cemozerr!
I'm extracting BLS interfaces right now to make underlying BLS library pluggable. May be it makes sense just to make another BLS library implementation which just doesn't do any verification? It would look more uniform.

@Nashatyrev
Copy link
Contributor

BTW do you think it makes sense to have a hidden command line option to disable verification? I regularly disable verification by modifying the code to speed up sync when debugging

Copy link
Contributor

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please address my comment on localizing flag usage
When BLS interfaces refactoring is ready I would adjust switching BLS off

@cemozerr cemozerr merged commit 13a323b into ConsenSys:master Jul 16, 2020
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to disable BLS verification for fuzzing
3 participants