Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWC links in html report #220

Merged
merged 2 commits into from Jun 18, 2019

Conversation

Projects
None yet
2 participants
@daniyarchambylov
Copy link
Collaborator

commented Jun 13, 2019

@daniyarchambylov daniyarchambylov requested a review from nbanmp Jun 13, 2019

helpers.js Outdated
@@ -382,7 +382,23 @@ function doReport(config, objects, errors) {
const uniqueIssues = eslintHelpers.getUniqueIssues(eslintIssuesByBaseName);

const formatter = getFormatter(config.style);
config.logger.log(formatter(uniqueIssues));
let formatterResult;
if (config.style === 'html') {

This comment has been minimized.

Copy link
@nbanmp

nbanmp Jun 13, 2019

Collaborator

Do we need to check the style here? Can we use the same rulesMeta for whatever style is chosen?

This comment has been minimized.

Copy link
@daniyarchambylov

daniyarchambylov Jun 18, 2019

Author Collaborator

Sure. It won't break anything on other formatters. I've updated PR. So please look at it

@nbanmp
Copy link
Collaborator

left a comment

works for me, just one comment

@nbanmp nbanmp merged commit 3b36e69 into master Jun 18, 2019

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.5%) to 66.634%
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: integrationTests Your tests passed on CircleCI!
Details
ci/circleci: publishImage Your tests passed on CircleCI!
Details
ci/circleci: tagImage Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.