Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Publish to consensys/ethsigner docker namespace and tidy up old config #385

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Publish to consensys/ethsigner docker namespace and tidy up old config #385

merged 3 commits into from
Sep 15, 2021

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Sep 13, 2021 •
edited
Loading

Fixes #384

  • remove the deprecated pegasyseng/ethsigner
  • deprecate consensys/quorum-ethsigner message to be added in docker repo
  • change publishing to use consensys/ethsigner

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jframe
jframe reviewed Sep 14, 2021
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@siladu
Add publishing to docker namespace "consensys/ethsigner"
acb1313 
Deprecating docker namespace "consensys/quorum-ethsigner"

Fixes Consensys#384
@siladu siladu marked this pull request as ready for review September 14, 2021 05:21
usmansaleem
usmansaleem approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jframe
jframe reviewed Sep 15, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@siladu siladu changed the title Remove pegasyseng docker tag and push config Publish to consensys/ethsigner and tidy up old config Sep 15, 2021
@siladu siladu changed the title Publish to consensys/ethsigner and tidy up old config Publish to consensys/ethsigner docker namespace and tidy up old config Sep 15, 2021
@siladu siladu merged commit 7281280 into Consensys:master Sep 15, 2021
@siladu siladu deleted the 384_only_publish_to_consensys_dockerhub branch September 15, 2021 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jframe jframe jframe left review comments

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate and discontinue publishing to dockerhub pegasyseng
4 participants
@siladu @CLAassistant @usmansaleem @jframe