feat: upgrade go corset #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
OlivierBBB
reviewed
Sep 10, 2025
There was a problem hiding this comment.
🟢
The REL_BLOCK / BLK_NUMBER pair is the culprit.
It's fixable.
There was a problem hiding this comment.
🟢
fixable
blockhash.macro/REL_BLOCK :i16
hub.BLK_NUMBER :i24
pair is the culprit.
There was a problem hiding this comment.
🔴
mismatch between
loginfo.DATA_SIZE ???
[hub.stack/STACK_ITEM_VALUE_LO 2] :i128
There was a problem hiding this comment.
🟢
Fixable, MXP_WORDS is far too big
hub.misc/MXP_WORDS :i128
mxp.macro/RES :i32
There was a problem hiding this comment.
🟡 likely not fixable due to
trm.TRM_ADDRESS_HI ??? // likely :i20
rlptxn.cmp/EXO_DATA_1 ??? // likely :i18There was a problem hiding this comment.
🔴 likely unfixable since STP uses the RES column for lookups into WCP and MOD
There was a problem hiding this comment.
❓
for the +1/-1 and constant target reasons
DavePearce
force-pushed
the
747-feat-upgrade-go-corset
branch
from
35a273a to
97db0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.