Prague folders and small Cancun fixes #769
Conversation
Cancun does not require the BLS_REFTABLE
- removed OOB -> BLS_REFTABLE lookup for Cancun - created oob/prague - did not include oob/cancun/cancun_restriction from the oob/prague
does not include constraints/tx_skip/sysi/eip-2935/disallow_prior_to_PRAGUE.lisp
bug had already been spotted by @lorenzo, using RSLT_XXX rather than DATA_XXX to set CT_MAX in BLS module the blsdata/prague does not include the blsdata/cancun/generalities/cancun_restriction.lisp file
OlivierBBB
requested review from
Copilot,
letypequividelespoubelles and
lorenzogentile404
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces the Prague folder structure with fixes for smaller Cancun issues. The changes reorganize transaction processing constraints into modular folders based on transaction phases (TX_SKIP, TX_INIT, TX_FINL, TX_PREWARM) and instruction handling, along with supporting constraints for system operations, storage, stacks, and miscellaneous functionality.
- Establishes a modular Prague folder structure separating transaction phases and instruction types
- Implements comprehensive transaction lifecycle constraints from initialization to finalization
- Adds support for transient storage operations and various EVM instruction handling
Reviewed Changes
Copilot reviewed 272 out of 365 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| hub/prague/constraints/tx_skip/sysf/* | System final transaction skip constraints and peeking flags |
| hub/prague/constraints/tx_skip/noop/* | No-operation transaction skip handling and flags |
| hub/prague/constraints/tx_init/* | Transaction initialization phase with account operations and context setup |
| hub/prague/constraints/tx_finl/* | Transaction finalization including gas refunds and coinbase rewards |
| hub/prague/constraints/tx_prewarm/* | Transaction prewarming constraints for account and storage access |
| hub/prague/constraints/system/* | Core system constraints for stamps, flags, and transaction numbers |
| hub/prague/constraints/instruction-handling/* | EVM instruction processing including storage, stack operations, and state management |
| hub/prague/constraints/miscellaneous-rows/* | Helper constraints for memory expansion, out-of-bounds checks, and module interactions |
| hub/prague/constraints/storage-rows/* | Storage operation specialized constraints and binary flags |
| hub/prague/constraints/stack-patterns/* | Stack manipulation patterns for various instruction types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Olivier Bégassat <38285177+OlivierBBB@users.noreply.github.com>
this relationship fails starting with EIP-7623 (Prague)
…nsensys/linea-constraints into prague-folders-and-small-cancun-fixes
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
2 similar comments
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
🔗 Link your GitHub account to AtlassianTo enable Code Reviewer, please link your GitHub account to your Atlassian account. Click here to connect your accounts This is a one-time setup that takes less than a minute. |
No description provided.