Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7549 aggregating pool filter phase0 att in electra #8303

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented May 8, 2024

We don't want to select phase0 attestations when electra enables.

Related to #7965

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@rolfyone
Copy link
Contributor

rolfyone commented May 8, 2024

so this is a step forward for sure, now can create blocks in a single node configuration...

in a multi-node minimal setup, aggregates are getting rejected over the wire with messages like:

09:53:46.354 ERROR - Validator   *** Produced invalid aggregate for slot 47: Rejecting aggregate because attester is not in committee. Should have been one of [82, 26, 7, 88]
09:53:46.354 ERROR - Validator   *** Produced invalid aggregate for slot 47: Rejecting aggregate because attester is not in committee. Should have been one of [82, 26, 7, 88]
09:53:46.355 ERROR - Validator   *** Produced invalid aggregate for slot 47: Rejecting aggregate because attester is not in committee. Should have been one of [82, 26, 7, 88]
09:53:46.356 INFO  - Validator   *** Published aggregate          Count: 1, Slot: 47, Root: 133cd269c309cc4aa48f380081ccc43b006b48be26acac14d33bd661ba1b9846

not sure if its my config...

Definitely better than previous where blocks were not being produced even in a single node, but I figured i'd give a bigger statement of progress in case it helps narrow things down...

@rolfyone
Copy link
Contributor

rolfyone commented May 9, 2024

ok so

  • 2 nodes on minimal-electra kind of setup is ok up to and including 63 validators, at 64 the aggregator issues start, it might be a committee calculation issue...
  • single minimal-electra node with 64 keys does actually show the issue - i had previously used less validators so didn't see it.

@tbenr
Copy link
Contributor Author

tbenr commented May 9, 2024

Ye the aggregation during block production is not done yet (currently it is still doing phase0 aggregation which can produce broken blocks)

A PR for this is planned :)

@tbenr tbenr enabled auto-merge (squash) May 9, 2024 07:58
@tbenr tbenr merged commit 5decca9 into Consensys:master May 9, 2024
16 checks passed
@tbenr tbenr deleted the 7549-aggregating-pool-filter-phase0-att-in-electra branch May 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants