Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Seat's CanGraphical property on the D-Bus #137

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented Jul 23, 2023

No description provided.

@arrowd arrowd mentioned this pull request Jul 28, 2023
@arrowd
Copy link
Contributor Author

arrowd commented Aug 8, 2023

@rnagy Can we get this in too?

@rnagy
Copy link
Collaborator

rnagy commented Aug 8, 2023

What was the use-case for this again?

@arrowd
Copy link
Contributor Author

arrowd commented Aug 8, 2023

This is yet another compatibility shim with login1. SDDM tries to access this property for each Seat it obtains from ListSeats.

@rnagy
Copy link
Collaborator

rnagy commented Aug 8, 2023

Ah okay. I see. I still think that you can't take copyright just by adding a function to that file,
please amend the commit message to include the company sponsorship.

@arrowd
Copy link
Contributor Author

arrowd commented Aug 8, 2023

What's wrong with adding copyrights? I'd take them out if I could, but it my company's requirement to put them anywhere I touch the code. It'd be much easier for me to contribute if I won't need to go through our lawyer each time asking her if it's OK to remove the copyright in this specific case.

@rnagy rnagy merged commit 8251861 into ConsoleKit2:master Aug 23, 2023
@arrowd arrowd deleted the can-graphical branch September 17, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants